ggml : add a set of functions for checking contiguity of inner tensor dimensions - #25650
Merged
Merged
Conversation
github-actions
Bot
added
the
ggml
ggerganov
approved these changes
Jul 14, 2026
Contributor
Author
|
@pwilkin Since you are familiar with the matter after yesterdays discussion can I get a review? |
giveen
pushed a commit
to giveen/llama-cpp-turboquant
that referenced
this pull request
Jul 18, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
CowboyTim
pushed a commit
to aardbeiplantje/llama.cpp
that referenced
this pull request
Jul 21, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
RehanQasim-dev
pushed a commit
to aifoundry-org/llama.cpp
that referenced
this pull request
Jul 23, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
RehanQasim-dev
pushed a commit
to aifoundry-org/llama.cpp
that referenced
this pull request
Jul 23, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
smalinin
pushed a commit
to smalinin/llama.cpp
that referenced
this pull request
Aug 4, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
… dimensions (ggml-org#25650) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds another set of GGML API
ggml_is_contiguous_to_[1-3]()functions (complementary to existingggml_is_contiguous_[0-2]()for checking contiguity of inner tensor dimensions. The meaning is that tensor dimensions < n are checked for contiguity while contiguity of dimensions >= n is irrelevant.Additional information
It reuses existing
ggml_is_contiguous_n()implementation by adding another parameter to control a range of dimensions when checking contiguity (old parameternthat controls the lower limit was renamed tom, newly addednparameter controls the upper limit).Requirements