Skip to content

gguf : harden loader against malformed tensor dims and metadata types #25596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 3 commits into from
Aug 12, 2026
+42 −11
Merged

gguf : harden loader against malformed tensor dims and metadata types #25596

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4705c84
gguf : harden loader against malformed tensor dims and metadata types
harrison001 Jul 12, 2026
3cd5206
gguf: address review on malformed-metadata hardening
harrison001 Jul 13, 2026
c970b26
cont : less comments
ggerganov Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ggml/src/gguf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,11 @@ static struct gguf_context * gguf_init_from_reader(const struct gguf_reader & gr
GGML_ASSERT(int64_t(ctx->kv.size()) == n_kv);

const int alignment_idx = gguf_find_key(ctx, GGUF_KEY_GENERAL_ALIGNMENT);
if (alignment_idx != -1 && gguf_get_kv_type(ctx, alignment_idx) != GGUF_TYPE_UINT32) {
GGML_LOG_ERROR("%s: alignment key has wrong type\n", __func__);
Comment thread
harrison001 marked this conversation as resolved.
Outdated
gguf_free(ctx);
return nullptr;
}
ctx->alignment = alignment_idx == -1 ? GGUF_DEFAULT_ALIGNMENT : gguf_get_val_u32(ctx, alignment_idx);

if (ctx->alignment == 0 || (ctx->alignment & (ctx->alignment - 1)) != 0) {
Expand Down Expand Up @@ -682,7 +687,8 @@ static struct gguf_context * gguf_init_from_reader(const struct gguf_reader & gr
}

// check that the total number of elements is representable
if (ok && ((INT64_MAX/info.t.ne[1] <= info.t.ne[0]) ||
if (ok && info.t.ne[1] != 0 && info.t.ne[2] != 0 && info.t.ne[3] != 0 &&
((INT64_MAX/info.t.ne[1] <= info.t.ne[0]) ||
Comment thread
harrison001 marked this conversation as resolved.
Outdated
(INT64_MAX/info.t.ne[2] <= info.t.ne[0]*info.t.ne[1]) ||
(INT64_MAX/info.t.ne[3] <= info.t.ne[0]*info.t.ne[1]*info.t.ne[2]))) {

Expand Down