Repository navigation
CUDA: dedup MoE gate/up activation quantization #25441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JohannesGaessler
merged 8 commits into
ggml-org:master
from
praneshgo:pgonegandla/moe_quant_optimize
Jul 16, 2026
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f286cf
CUDA: dedup MoE gate/up activation quantization (fp4)
praneshgo a155c70
CUDA: bounds-check token ids in build_tok2c_kernel
praneshgo 1327f42
Refactor the code based on review comments
praneshgo 1c687ce
Adding q8_1 support for dedup and addressing review comments
praneshgo 5fda553
Add pragma unrolls
praneshgo afd0239
Remove redundant cudaMemsetAsync call
praneshgo b93a436
Removing follow up redundancies
praneshgo bc67b43
Merge branch 'master' of https://github.com/ggml-org/llama.cpp into p…
praneshgo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add this call to
cudaMemsetAsync? I don't think it's needed,ids_src1should be completely initialized even with the inverse mapping. I am not getting incorrect results from removing this call, I do however see an end-to-end performance difference of up to 5% on my RTX 5090.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, it is in fact redundant. I had initially added it to initialize -1 for unwritten slots, but mm_ids_helper fills every (token, slot) entry, so all the slots are initialized anyway. Removed it in the latest commit.