common: sort safetensor files to prevent illegal split error at loadi… - #25183
Closed
adrianhoehne wants to merge 1 commit into
Closed
Conversation
Collaborator
|
not 100% if this could be a duplicated code path, cc @angt if you can have a look |
adrianhoehne
deleted the
fix-hf-split-file-order-causing-crash-at-model-load
branch
July 1, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng model.
fixes(#25181)
Overview
When hf is set then the files of the specific folder are read in, this may happen unordered, so at the end the wrong safetensor file is given to the main logic and will cause an "illegal split file idx error.
This code just sorts the list by index before returning it to the caller.
Additional information
Requirements
It is reproduce and tested with the following configuration: