Skip to content

vulkan: Workaround compiler bug in conv2d coopmat2 path - #24924

Merged
0cc4m merged 3 commits into
ggml-org:masterfrom
jeffbolznv:conv2d_mm_workaround
Jun 26, 2026
Merged

vulkan: Workaround compiler bug in conv2d coopmat2 path#24924
0cc4m merged 3 commits into
ggml-org:masterfrom
jeffbolznv:conv2d_mm_workaround

Conversation

@jeffbolznv

Copy link
Copy Markdown
Contributor

Overview

This fixes a failure seen in https://github.com/leejet/stable-diffusion.cpp. The compiler messed up alignment with the odd size array.

Requirements

@jeffbolznv
jeffbolznv requested review from a team and ggerganov as code owners June 22, 2026 23:42
@github-actions github-actions Bot added testing Everything test related Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jun 22, 2026
@jeffbolznv
jeffbolznv force-pushed the conv2d_mm_workaround branch from 43e96c5 to 1add6e7 Compare June 23, 2026 14:39
Comment thread ggml/src/ggml-vulkan/vulkan-shaders/conv3d_mm.comp Outdated
@0cc4m
0cc4m merged commit 9df0680 into ggml-org:master Jun 26, 2026
26 of 27 checks passed
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
* vulkan: Workaround compiler bug in conv2d coopmat2 path

* apply same workaround to CONV_3D

* Apply suggestion from @jeffbolznv
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
* vulkan: Workaround compiler bug in conv2d coopmat2 path

* apply same workaround to CONV_3D

* Apply suggestion from @jeffbolznv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning testing Everything test related Vulkan Issues specific to the Vulkan backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants