fix(vulkan-shaders-gen): fail build when shader compile subprocess fails - #24921
Closed
Nueramarcos wants to merge 2 commits into
Closed
fix(vulkan-shaders-gen): fail build when shader compile subprocess fails#24921Nueramarcos wants to merge 2 commits into
Nueramarcos wants to merge 2 commits into
Conversation
execute_command() now returns the child exit code (POSIX waitpid / Windows GetExitCodeProcess). string_to_spv_func treats non-zero exit, stderr output, or launch exceptions as failure via compile_failed. main() returns EXIT_FAILURE before write_output_files() so CMake stops instead of linking a silently broken libggml-vulkan. Fixes ggml-org#24393
github-actions
Bot
added
Vulkan
Contributor
|
Already covered by #24450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24393
execute_command()now propagates subprocess exit codes (POSIXwaitpid/ WindowsGetExitCodeProcess).string_to_spv_func()records failures viacompile_failedwhen the child exits non-zero, writes to stderr, or fails to launch.main()returnsEXIT_FAILUREbeforewrite_output_files()so CMake stops instead of linking a silently brokenlibggml-vulkan.Validated locally with
g++ -std=c++17 -fsyntax-only. Build-time only; no runtime or shader output change. No GPU required.