mtmd: refactor llava-uhd overview image handling (always use ov_img_first) - #24769
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
nvm, this seems good, I'm merging it now to unblock the other PR |
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
…irst) (ggml-org#24769) * add dedicated "overview" for mtmd_image_preproc_out * corrections * correct (again) * nits * nits (2)
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
…irst) (ggml-org#24769) * add dedicated "overview" for mtmd_image_preproc_out * corrections * correct (again) * nits * nits (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Important
if you get the error "no image tokens produced by preprocessor", comment below the model you are using (link to GGUF file) as well as the input image size that you are using
llava-uhd overview image logic is a bit messy, because some models hard-coding the handling inside preprocessor, while the other rely on
ov_img_firstWith this PR,
ov_img_firstis now the single source of truth.Test results:
Requirements