Skip to content

chat: include full unparsed prompt in debug message on parse error - #24650

Merged
pwilkin merged 2 commits into
masterfrom
add-long-debug-prompt
Jun 15, 2026
Merged

chat: include full unparsed prompt in debug message on parse error#24650
pwilkin merged 2 commits into
masterfrom
add-long-debug-prompt

Conversation

@pwilkin

@pwilkin pwilkin commented Jun 15, 2026

Copy link
Copy Markdown
Member

As in topic.

Overview

Minimal change to enable dumping full unparsed prompt.

Additional information

Need for debugging parser errors.

Requirements

@pwilkin
pwilkin requested a review from a team as a code owner June 15, 2026 11:23
@pwilkin

pwilkin commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

@ggml-org/maintainers need 2 quick approvals on this one.

@pwilkin pwilkin closed this Jun 15, 2026
@pwilkin

pwilkin commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Superseded (already part of) #24329

@ServeurpersoCom

Copy link
Copy Markdown
Contributor

Superseded (already part of) #24329

So we had the same problem

@pwilkin

pwilkin commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Ah, but I didn't realize it's not the same - it doesn't display the entire input. Never mind, I'll modify it :)

@pwilkin pwilkin reopened this Jun 15, 2026
@pwilkin
pwilkin merged commit 38d5463 into master Jun 15, 2026
25 checks passed
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants