mtmd: add batching API#24384
Draft
ngxson wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Supersede #24300
Also fix #24380
Add a generic batching API to mtmd and wire it up to
llama-server, the goal is to speed up llava-uhd-style models and at the same time, improve video processing speedCurrent state:
llama-servercan use it correctlyTODO:
mtmd_batch_add_chunkshould only accept input with same sizemtmd_batch_encodeto use the 4th batch dim, added via mtmd: build_vit batching #24352build_vit()models for nowmtmd-clito reflect the usage --> not sure, maybe a follow-up PR is betterRequirements