CUDA: remove -sm row, refactor cuBLAS#24216
Open
JohannesGaessler wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Sorry, I accidentally pushed the wrong logic for CDNA + BF16. This is the performance with the correct logic: Performance
|
Contributor
Author
|
The CI was failing because I had accidentally copied a return statement when restructuring the code. The code paths on which I tested the performance were unaffected. |
CISC
approved these changes
Jun 6, 2026
6bcdfe5 to
fdf64b8
Compare
gaugarg-nv
reviewed
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes CUDA backend support for split buffers (
--split-mode row) - by now-sm tensorhas all of the necessary features to make it obsolete. Split buffers therefore do not need to be considered for #23935 . Also, it is possible to remove a lot of legacy code that predates the ggml backend API (ggml_cuda_op_mul_mat). I refactored and deduplicated the cuBLAS code to use only a single functions for both batched and non-batched GEMM. The compute type is chosen based on speed, can be overridden withGGML_CUDA_CUBLAS_COMPUTE_TYPE. I did some A/B testing for cuBLAS configuration which unlocked some FP16/BF16 performance for some GPUs.Performance
Requirements