Skip to content

ui: add ignore-scripts=true to npmrc#24149

Merged
allozaur merged 1 commit into
ggml-org:masterfrom
ngxson:xsn/npm_ignore_scripts
Jun 5, 2026
Merged

ui: add ignore-scripts=true to npmrc#24149
allozaur merged 1 commit into
ggml-org:masterfrom
ngxson:xsn/npm_ignore_scripts

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented Jun 4, 2026

Overview

add ignore-scripts=true to .npmrc

this avoids automatically running preinstall/postinstall/prepare during npm install, which may make things a bit safer

NOTE:

  • this is NOT a fail-safe solution, a malicious script can still be triggered via npm run dev or npm run build, but this limits to build time packages only (so, still reduce the attack surface)
  • I tested the change with dev and build script and things still work correctly
  • I asked AI to scan for how our dependencies are using it, and turns out none of them have preinstall or postinstall

Requirements

@ngxson ngxson requested a review from a team as a code owner June 4, 2026 23:03
@allozaur allozaur merged commit cc7bef3 into ggml-org:master Jun 5, 2026
6 checks passed
jimbothigpen pushed a commit to jimbothigpen/llama.cpp that referenced this pull request Jun 6, 2026
jimbothigpen pushed a commit to jimbothigpen/llama.cpp that referenced this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants