Docker action shouldn't run on PRs #241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action would run for every PR action which means it'll create a docker image every time the CI runs on contributions.
Contributor
|
IMO it makes sense to build the image so that the pipeline doesn’t unexpectedly break — since the images aren’t pushed anywhere it is safe to generate them. |
Contributor
Author
|
Oops, you're right, I did missed that the docker.yml conditionally pushes depending if it's a PR or a commit. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action would run for every PR action which means it'll create a docker image every time the CI runs on contributions.