Skip to content

ggml-webgpu: avoid using linear_indexing extension in cpy shader#23955

Merged
reeselevine merged 1 commit into
ggml-org:masterfrom
yomaytk:fix-cpy-bug
Jun 1, 2026
Merged

ggml-webgpu: avoid using linear_indexing extension in cpy shader#23955
reeselevine merged 1 commit into
ggml-org:masterfrom
yomaytk:fix-cpy-bug

Conversation

@yomaytk
Copy link
Copy Markdown
Contributor

@yomaytk yomaytk commented Jun 1, 2026

Overview

This PR fixes #23925. confirmed that I can correctly run inference on safari.

  • reverts to using global_invocation_id for cpy

I introduced global_invocation_index to the cpy shader in #23750 for simplicity, but I noticed it's actually a wgsl extension and safari doesn't seem to support it yet (chrome supports it now).
It looks like we could still use global_invocation_index on chrome by detecting linear_indexing support, but I think global_invocation_id is enough for now.

Requirements

@yomaytk yomaytk requested a review from a team as a code owner June 1, 2026 04:42
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning WebGPU labels Jun 1, 2026
@yomaytk
Copy link
Copy Markdown
Contributor Author

yomaytk commented Jun 1, 2026

@ngxson @reeselevine gentle ping, can either of you check if this fix lets you run it correctly in your environment? :)

Copy link
Copy Markdown
Contributor

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yomaytk @reeselevine for the quick response, I can confirm that it fixes the problem on safari

@reeselevine
Copy link
Copy Markdown
Contributor

thanks for the quick fix!

@reeselevine reeselevine merged commit b8275a8 into ggml-org:master Jun 1, 2026
17 of 19 checks passed
@yomaytk yomaytk deleted the fix-cpy-bug branch June 2, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: webgpu mul_mat fails on safari

3 participants