ggml-webgpu: avoid using linear_indexing extension in cpy shader#23955
Merged
Conversation
Contributor
Author
|
@ngxson @reeselevine gentle ping, can either of you check if this fix lets you run it correctly in your environment? :) |
ngxson
approved these changes
Jun 1, 2026
Contributor
ngxson
left a comment
There was a problem hiding this comment.
thanks @yomaytk @reeselevine for the quick response, I can confirm that it fixes the problem on safari
reeselevine
approved these changes
Jun 1, 2026
Contributor
|
thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes #23925. confirmed that I can correctly run inference on safari.
global_invocation_idfor cpyI introduced
global_invocation_indexto the cpy shader in #23750 for simplicity, but I noticed it's actually a wgsl extension and safari doesn't seem to support it yet (chrome supports it now).It looks like we could still use
global_invocation_indexon chrome by detectinglinear_indexingsupport, but I thinkglobal_invocation_idis enough for now.Requirements