Skip to content

server: minor tweaks to use more cpp features#23785

Merged
angt merged 4 commits into
ggml-org:masterfrom
mfuntowicz:cleanup-http-server
May 28, 2026
Merged

server: minor tweaks to use more cpp features#23785
angt merged 4 commits into
ggml-org:masterfrom
mfuntowicz:cleanup-http-server

Conversation

@mfuntowicz
Copy link
Copy Markdown
Contributor

Overview

This PR mostly attempts to move to wider usage of cpp compiler features over the llama HTTP server.

Among others:

  • More usage of const
  • More usage of auto
  • Replace C casts to C++ one(static_cast<>(...) here)
  • Avoid constructor uninitialized port parameter defaulting to 8080

Requirements

@mfuntowicz mfuntowicz requested a review from a team as a code owner May 27, 2026 15:19
@mfuntowicz mfuntowicz changed the title Cleanup http server server: minor tweaks to use more cpp features May 27, 2026
@angt
Copy link
Copy Markdown
Member

angt commented May 28, 2026

Welcome 🤗

@angt angt merged commit 0b24686 into ggml-org:master May 28, 2026
31 checks passed
@mfuntowicz mfuntowicz deleted the cleanup-http-server branch May 28, 2026 12:18
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request May 28, 2026
* misc(server): add default port to impl RAII

* misc(server): register_gcp_compat() can be const

* misc(server): use proper cpp const/auto methods

* misc(server): do not reset a unique_ptr, use make_unique instead to be exception safe
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request May 28, 2026
* origin/master: (32 commits)
hexagon: basic/generic op fusion support and RMS_NORM+MUL fusion (ggml-org#23835)
mtmd-debug: add color and rainbow mode (ggml-org#23829)
mtmd: fix gemma 4 projector pre_norm (ggml-org#23822)
opencl: move backend info printing into its own function (ggml-org#23702)
ci : run ui publish on ubuntu-slim (ggml-org#23818)
ui: fix audio and video modality detection (ggml-org#23756)
ci : releases use Github-hosted builds for the UI (ggml-org#23823)
app : improve help output (ggml-org#23805)
mtmd: n_head_kv defaults to n_head (ggml-org#23782)
mtmd: fix gemma 4 audio rms norm eps (ggml-org#23815)
ci : change Vulkan builds to Release to reduce ccache (ggml-org#23820)
arg: Add LLAMA_ARG_API_KEY_FILE environment variable for --api-key-file (ggml-org#23167)
test-llama-archs: fix table format [no release] (ggml-org#23810)
ggml: auto apply iGPU flag CUDA/HIP if integrated device (ggml-org#23007)
mmvq Optim: add MMVQ_PARAMETERS_TURING(mmvq_parameter_table_id) for … (ggml-org#23729)
CUDA: route batch>=4 quantized matmul to MMQ on AMD MFMA hardware (ggml-org#23227)
server: minor tweaks to use more cpp features (ggml-org#23785)
hexagon: minor refresh for HMX FA and MM (ggml-org#23796)
vulkan: fast path for walsh-hadamard transform (ggml-org#23687)
chat : add Granite 4.1 chat template (ggml-org#23518)
...
fewtarius pushed a commit to fewtarius/llama.cpp that referenced this pull request May 30, 2026
* misc(server): add default port to impl RAII

* misc(server): register_gcp_compat() can be const

* misc(server): use proper cpp const/auto methods

* misc(server): do not reset a unique_ptr, use make_unique instead to be exception safe
turbo-tan pushed a commit to turbo-tan/llama.cpp-tq3 that referenced this pull request Jun 2, 2026
* misc(server): add default port to impl RAII

* misc(server): register_gcp_compat() can be const

* misc(server): use proper cpp const/auto methods

* misc(server): do not reset a unique_ptr, use make_unique instead to be exception safe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants