server: reprocess instead of aborting after failing to restore unified KV cache checkpoint - #23723
Closed
NickM-27 wants to merge 2 commits into
Closed
server: reprocess instead of aborting after failing to restore unified KV cache checkpoint#23723NickM-27 wants to merge 2 commits into
NickM-27 wants to merge 2 commits into
Conversation
NickM-27
changed the title
NickM-27
changed the title
Member
|
Superseded by #23981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the context checkpoint functions to return a boolean if the checkpoint was able to be restored, allowing falling back to full reprocessing instead of aborting.
Additional information
This fixes #23720 which I provided more information and reproduction steps for.
I understand there may be other reasons for the abort, so perhaps this should be fixed somewhere else to avoid getting to that point. It does seem preferable though to fully reprocess vs abort.
Requirements