ggml: Check the right iface method before using the fallback 2d get#23514
Merged
Conversation
CISC
approved these changes
May 22, 2026
github-actions
Bot
added
the
ggml
taronaeo
approved these changes
May 22, 2026
kashif
pushed a commit
to kashif/llama.cpp
that referenced
this pull request
May 23, 2026
spiritbuun
pushed a commit
to spiritbuun/buun-llama-cpp
that referenced
this pull request
May 25, 2026
7 tasks
Draft
fewtarius
pushed a commit
to fewtarius/llama.cpp
that referenced
this pull request
May 30, 2026
turbo-tan
pushed a commit
to turbo-tan/llama.cpp-tq3
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Same oversight as #23306 but for the async (backend-based) path.
Additional information
ggml_backend_tensor_get_2d_asyncwas checkingset_tensor_2d_asyncinstead ofget_tensor_2d_async, and the bounds assertion said "write" when it should say "read".Let me know if this fix is appropriate, or if there's a better way to handle this.
Requirements