Add keepalive messages to HTTP streaming connections#23355
Closed
komadori82 wants to merge 1 commit into
Closed
Conversation
Closes ggml-org#22997 Long prompts can cause intermediaries to time out and close idle connections after 300s (5m). This patch adds a keepalive messaging system that lets the intermediaries know we're still running during long waits.
Contributor
|
the implementation is too hacky, we cannot accept. everything related to HTTP layer should stays at HTTP layer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22997
Long prompts can cause intermediaries to time out
and close idle connections after 300s (5m). This
patch adds a keepalive messaging system that lets
the intermediaries know we're still running during long waits.
Overview
Adds a keepalive to let http connectors know that we're not gone
Requirements
none
yes
yes, it helped me with adding the http keepalive code.