logs : reduce#23021
Conversation
| if (!is_resume) { | ||
| mtmd_helper_log_set(common_log_default_callback, nullptr); | ||
| } |
There was a problem hiding this comment.
@ngxson Wasn't sure what is the intent here of gating this with is_resume. I just moved the mtmd log initialization to the constructor server_context_impl(). Please confirm this is OK.
There was a problem hiding this comment.
the reason why it's gated was because mtmd_helper_log_set is not thread-safe, so it should only be called once when the program starts.
although, there is another way, you can call mtmd_helper_log_set unconditionally in server_context_impl::init() function
|
@ggml-org/maintainers After this change the server logs will be quite reduced by default. You can easily go back to the old amount of logs if you are used to them by adding |
pwilkin
left a comment
There was a problem hiding this comment.
Good change, I like the added verbosity levels. Previously it was really hard to find a balance between standard mode that hid a lot of things and verbose mode that spammed tons of info on every token generated.
| server_context_impl() { | ||
| mtmd_helper_log_set(common_log_default_callback, nullptr); | ||
| } | ||
|
|
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
- Opt-in flag that surfaces the per-device free-memory probe table (currently TRACE-only after ggml-org#23021) at INFO when set; default off.
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
* logs : reduce * args : fix envs * server : fix build * common : print verbosity level at start * server : clean-up logs * server : print prompt processing timings + sampling params * minor : whitespaces
Overview
Reducing the amount of logs that we print by default. Feedback is welcome about what to remove further and what to keep.
Additional information
LOG_LEVEL_TRACE = 4LOG_LEVEL_DEBUGfrom 4 to 5INFOlogs coming fromlibllama,libmtmdandlibggml*toLOG_LEVEL_TRACElibcommonaccordinglyThe old level of logging can be enabled by adding
-lv 4to the CLI args.Requirements