Skip to content

webui: Deduplicate model aliases in data + handle single/multiple aliases in UI#22979

Merged
allozaur merged 2 commits into
ggml-org:masterfrom
allozaur:22510-fix-model-selection-errors
May 13, 2026
Merged

webui: Deduplicate model aliases in data + handle single/multiple aliases in UI#22979
allozaur merged 2 commits into
ggml-org:masterfrom
allozaur:22510-fix-model-selection-errors

Conversation

@allozaur
Copy link
Copy Markdown
Contributor

Overview

Close #22510

Requirements

Copilot AI review requested due to automatic review settings May 12, 2026 15:53
@allozaur allozaur requested a review from a team as a code owner May 12, 2026 15:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the model ID display in the web UI to deduplicate aliases/tags and to present a different layout when there is exactly one alias (alias becomes the display name).

Changes:

  • Deduplicate aliases and combined tags via Set.
  • Introduce “primary alias” behavior: if exactly one alias exists, use it as the display name and show the raw model name as a badge.
  • Render multiple aliases as badges; render deduplicated tags as badges.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/server/webui/src/lib/components/app/models/ModelId.svelte Outdated
Comment thread tools/server/webui/src/lib/components/app/models/ModelId.svelte Outdated
Copy link
Copy Markdown
Contributor

@ServeurpersoCom ServeurpersoCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question on Copilot's #2: was switching aliases from badgeClass to tagBadgeClass intentional (visual unification with tags) ?
Also a tiny nit: when primaryAlias === parsed.modelName, the badge would duplicate the display name. Rare in practice!

@allozaur allozaur force-pushed the 22510-fix-model-selection-errors branch from 781ddc5 to 8643f7b Compare May 13, 2026 14:03
@allozaur
Copy link
Copy Markdown
Contributor Author

Quick question on Copilot's #2: was switching aliases from badgeClass to tagBadgeClass intentional (visual unification with tags) ? Also a tiny nit: when primaryAlias === parsed.modelName, the badge would duplicate the display name. Rare in practice!

8643f7b

@allozaur allozaur requested a review from ServeurpersoCom May 13, 2026 14:03
@allozaur allozaur force-pushed the 22510-fix-model-selection-errors branch from 8643f7b to 826ab6f Compare May 13, 2026 14:20
@allozaur allozaur merged commit 2dfeca3 into ggml-org:master May 13, 2026
7 checks passed
xxmustafacooTR pushed a commit to xxPlayground/llama-cpp-turboquant that referenced this pull request May 13, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
@allozaur allozaur deleted the 22510-fix-model-selection-errors branch May 14, 2026 17:06
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 19, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request May 19, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
baramofme pushed a commit to baramofme/llama-cpp-turboquant that referenced this pull request May 23, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
winstonma pushed a commit to winstonma/llama.cpp that referenced this pull request May 27, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
fewtarius pushed a commit to fewtarius/llama.cpp that referenced this pull request May 30, 2026
…ases in UI (ggml-org#22979)

* fix: Deduplicate aliases + display single alias instead of default name or 2+ aliases as tags

* refactor: Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: webui unable to select model with error http error 500, 404

4 participants