Skip to content

ci: validate model naming convention#22680

Merged
ngxson merged 4 commits into
ggml-org:masterfrom
ngxson:xsn/validate_model_filename
May 13, 2026
Merged

ci: validate model naming convention#22680
ngxson merged 4 commits into
ggml-org:masterfrom
ngxson:xsn/validate_model_filename

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented May 4, 2026

Overview

Enforce naming convention as discussed in #22004 (comment)

Example:

  • arch name: LLM_ARCH_ABC_DEF_V123
  • model class name: llama_model_abc_def_v123
  • file name: src/models/abc-def-v123.cpp

Requirements

@ngxson ngxson requested a review from a team as a code owner May 4, 2026 14:10
@ngxson ngxson requested a review from CISC May 4, 2026 14:11
@github-actions github-actions Bot added the devops improvements to build systems and github actions label May 4, 2026
@CISC
Copy link
Copy Markdown
Member

CISC commented May 4, 2026

Hm, not sure we want this in the same workflow file as EditorConfig, if it's separate we could run it only for changes to model files.

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented May 4, 2026

Hmm yeah but at the same time I don't want to create too many files for small workflows like this one.

And btw, to save some precious CI running time, I'm actually thinking about doing the reverse: group more style-related workflows into a single run

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented May 4, 2026

we could run it only for changes to model files.

I would argue that if we group more checks into a single run, then more checks add almost no costs. The time it takes is more likely for preparing the CI (getting queued, pull commits, install deps)

@CISC
Copy link
Copy Markdown
Member

CISC commented May 5, 2026

we could run it only for changes to model files.

I would argue that if we group more checks into a single run, then more checks add almost no costs. The time it takes is more likely for preparing the CI (getting queued, pull commits, install deps)

Sure, but they would have to all be steps within the same job, not separate jobs like here.

Either way, I think EditorConfig is important enough to deserve to live alone.

@ngxson
Copy link
Copy Markdown
Contributor Author

ngxson commented May 12, 2026

sorry for the delay, can you have a look on latest change? @CISC

Comment on lines -5 to -9
inputs:
create_release:
description: 'Create new release'
required: true
type: boolean
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a bad copy-paste

@ngxson ngxson requested a review from a team May 12, 2026 17:42
@ngxson ngxson merged commit 3796c94 into ggml-org:master May 13, 2026
3 checks passed
xxmustafacooTR pushed a commit to xxPlayground/llama-cpp-turboquant that referenced this pull request May 13, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 19, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request May 19, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
baramofme pushed a commit to baramofme/llama-cpp-turboquant that referenced this pull request May 23, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
carlosfundora pushed a commit to carlosfundora/llama.cpp-1-bit-turbo that referenced this pull request May 24, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
(cherry picked from commit 3796c94)
winstonma pushed a commit to winstonma/llama.cpp that referenced this pull request May 27, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
fewtarius pushed a commit to fewtarius/llama.cpp that referenced this pull request May 30, 2026
* ci: validate model naming convention

* bring back dedicated ec workflow

* add missing jobs

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants