Skip to content

cpu : re-enable fast gelu_quick_f16#22339

Merged
ggerganov merged 1 commit into
masterfrom
cisc/use-fast-gelu-quick-f16
Apr 26, 2026
Merged

cpu : re-enable fast gelu_quick_f16#22339
ggerganov merged 1 commit into
masterfrom
cisc/use-fast-gelu-quick-f16

Conversation

@CISC
Copy link
Copy Markdown
Member

@CISC CISC commented Apr 24, 2026

Overview

Enable disabled ggml_vec_gelu_quick_f16.

Additional information

I couldn't find any reason why this was disabled, and the current version is 10-20x slower.

Another puzzling fact is that we use the same table for ggml_vec_gelu_quick_f32 (as GGML_GELU_QUICK_FP16 is enabled) so there should be no issue?

Requirements

@CISC CISC requested a review from ggerganov as a code owner April 24, 2026 22:42
@github-actions github-actions Bot added the ggml changes relating to the ggml tensor library for machine learning label Apr 24, 2026
@ggerganov ggerganov added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 25, 2026
@ggerganov ggerganov merged commit 0c6ee1c into master Apr 26, 2026
76 of 81 checks passed
@ggerganov ggerganov deleted the cisc/use-fast-gelu-quick-f16 branch April 26, 2026 06:28
IntelNav pushed a commit to IntelNav/llama.cpp that referenced this pull request Apr 29, 2026
IntelNav pushed a commit to IntelNav/llama.cpp that referenced this pull request Apr 29, 2026
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
samuraieng pushed a commit to samuraieng/llama.cpp that referenced this pull request May 6, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
meh pushed a commit to meh/llama.cpp that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants