CUDA: better coalesce data-access for contiguous concat#22330
Merged
JohannesGaessler merged 1 commit intoApr 26, 2026
Conversation
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
JohannesGaessler
approved these changes
Apr 25, 2026
am17an
approved these changes
Apr 25, 2026
IntelNav
pushed a commit
to IntelNav/llama.cpp
that referenced
this pull request
Apr 29, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
IntelNav
pushed a commit
to IntelNav/llama.cpp
that referenced
this pull request
Apr 29, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
rsenthilkumar6
pushed a commit
to rsenthilkumar6/llama.cpp
that referenced
this pull request
May 1, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
samuraieng
pushed a commit
to samuraieng/llama.cpp
that referenced
this pull request
May 6, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
meh
pushed a commit
to meh/llama.cpp
that referenced
this pull request
May 10, 2026
Also, distribute all elements across CTAs evenly instead of launching one CTA per dim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stumbled upon this when looking at an nsight trace for a hybrid mamba model.
Nsight compute revealed uncoalesced data-access (especially stores) for typical LLM token-gen workloads in addition to launching a lot of CTAs. This PR addresses these two points, leading to 1-3% E2E perf gain.
I did not find perf tests in test-backend-ops for this, so I didn't have any other workloads to verify against perf regression (PP hits the non-cont
concat_f32_non_contkernel).Additional information
Requirements