Feature/add -ms option for modelscope - #22279
Conversation
|
Hi @yrk111222, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
I have closed the previous PR #21985 to comply with the single-PR rule for new contributors. |
31c96a5 to
ccd52dc
Compare
|
Hi @yrk111222, thanks for the update. |
ccd52dc to
9919f03
Compare
|
Hi @angt — thanks for the earlier review. I reworked this PR to remove duplication by switching to common_download_file_single and keeping only the ModelScope-specific bits (dropped the custom progress bar/download loop, extracted shared helpers). |
|
Hi @angt @ngxson , hope you’re having a great day! 😊 |
d3262d5 to
1d4359f
Compare
|
Hey @yrk111222 thanks for the update, there is still a duplication of the download code 👀 |
1d4359f to
e5c1eba
Compare
|
Expect the feature to be merged and released immediately |
9e29477 to
3419477
Compare
3419477 to
7d7edbb
Compare
|
Hi @angt, thanks for your feedback. Since your last review, I've further reduced duplication. |
|
Hi @angt. Friendly ping — could you take a look when you get a chance? Thanks! 😊 |
|
this has been pending for a while, could you please follow up and take a look when you got a chance? @angt @Leonard-Li777 thanks a bunch! |
|
Hey! We know this feature is requested by users, so we really appreciate the effort. But rn, we are rethinking our overall cache system and how users interact with it. Because of this upcoming redesign, several related PRs are currently on hold, and I apologize for the delay this causes. At the same time, this PR currently mixes a few different responsibilities. While we acknowledge that the existing codebase is already a bit messy, we want to avoid adding more technical debt before the redesign. All the logic for downloading, quantization selection, and filtering should stay in |
thanks @angt , we will be working on a revision according to your suggestions. |
|
Hello @angt Closing this one in favor of #24716. Happy to address any further feedback there! |
Overview
This PR introduces ModelScope integration for model downloading and loading.
Related PR: #20941
#21985
Key changes:
Added new cli arguments: -ms (ModelScope repo ID)
Added corresponding environment variables support for seamless configuration.
Enabled community model downloading via MODEL_ENDPOINT (defaults to https://modelscope.cn/), allowing flexible usage with or without explicit endpoint specification.
Usage examples:
Additional information
Requirements