sycl: support non-contiguous input in PAD op#22148
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
…bmg-upstream-pr-2
|
Looks like CI failures are due to unreliable tests. I will do a merge from upstream to trigger a rebuild. |
|
Thank you @NeoZhangJianyu @CISC ! Could you help us with the merge process? CI tests may require rebuild still due to instability. Thanks. |
CI failures are unrelated, @arthw will merge when ready. |
|
@ctao456 Thank you! |
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com> (cherry picked from commit c5703e0)
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Chun Tao <chun.tao@intel.com> Co-authored-by: Todd Malsbary <todd.malsbary@intel.com>
Overview
Authors
pad_f32previously assumed contiguous source strides and reconstructedne00/ne01/ne02fromne - lp - rp. This broke when the source tensor had non-contiguous strides (common for views).Pass
s00..s03(source strides in elements) through to the kernel and index withi03*s03 + i02*s02 + i01*s01 + i00*s00. Also switches the grid layout tosycl::range<3>order to match the rest of the backend.Additional information
Part of work originally submitted as #22066 — splitting per reviewer request.
Requirements