Skip to content

convert : support sentence-transformer 5.4 config files#22087

Merged
ggerganov merged 4 commits into
ggml-org:masterfrom
Bing-su:fix/st5_4
Apr 19, 2026
Merged

convert : support sentence-transformer 5.4 config files#22087
ggerganov merged 4 commits into
ggml-org:masterfrom
Bing-su:fix/st5_4

Conversation

@Bing-su
Copy link
Copy Markdown
Contributor

@Bing-su Bing-su commented Apr 18, 2026

Overview

Modify the _try_set_pooling_type function so that it can read the updated config file in sentence-transformers 5.4.

( config for google/embeddinggemma-300m )

modules.json

  • 5.3.0
[
  {
    "idx": 0,
    "name": "0",
    "path": "",
    "type": "sentence_transformers.models.Transformer"
  },
  {
    "idx": 1,
    "name": "1",
    "path": "1_Pooling",
    "type": "sentence_transformers.models.Pooling"
  },
  {
    "idx": 2,
    "name": "2",
    "path": "2_Dense",
    "type": "sentence_transformers.models.Dense"
  },
  {
    "idx": 3,
    "name": "3",
    "path": "3_Dense",
    "type": "sentence_transformers.models.Dense"
  },
  {
    "idx": 4,
    "name": "4",
    "path": "4_Normalize",
    "type": "sentence_transformers.models.Normalize"
  }
]
  • 5.4.1
[
  {
    "idx": 0,
    "name": "0",
    "path": "",
    "type": "sentence_transformers.base.modules.transformer.Transformer"
  },
  {
    "idx": 1,
    "name": "1",
    "path": "1_Pooling",
    "type": "sentence_transformers.sentence_transformer.modules.pooling.Pooling"
  },
  {
    "idx": 2,
    "name": "2",
    "path": "2_Dense",
    "type": "sentence_transformers.base.modules.dense.Dense"
  },
  {
    "idx": 3,
    "name": "3",
    "path": "3_Dense",
    "type": "sentence_transformers.base.modules.dense.Dense"
  },
  {
    "idx": 4,
    "name": "4",
    "path": "4_Normalize",
    "type": "sentence_transformers.sentence_transformer.modules.normalize.Normalize"
  }
]

1_Pooling/config.json

  • 5.3.0
{
    "word_embedding_dimension": 768,
    "pooling_mode_cls_token": false,
    "pooling_mode_mean_tokens": true,
    "pooling_mode_max_tokens": false,
    "pooling_mode_mean_sqrt_len_tokens": false,
    "pooling_mode_weightedmean_tokens": false,
    "pooling_mode_lasttoken": false,
    "include_prompt": true
}
  • 5.4.1
{
    "embedding_dimension": 768,
    "pooling_mode": "mean",
    "include_prompt": true
}

2_Dense/config.json

  • 5.3.0
{
    "in_features": 768,
    "out_features": 3072,
    "bias": false,
    "activation_function": "torch.nn.modules.linear.Identity"
}
  • 5.4.1
{
    "in_features": 768,
    "out_features": 3072,
    "bias": false,
    "activation_function": "torch.nn.modules.linear.Identity",
    "module_input_name": "sentence_embedding",
    "module_output_name": "sentence_embedding"
}

Additional information

all pooling mode

https://github.com/huggingface/sentence-transformers/blob/main/sentence_transformers/sentence_transformer/modules/pooling.py

Requirements

@Bing-su Bing-su requested a review from CISC as a code owner April 18, 2026 16:04
@github-actions github-actions Bot added the python python script changes label Apr 18, 2026
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing all the examples, very useful.

Comment thread convert_hf_to_gguf.py Outdated
Comment thread convert_hf_to_gguf.py Outdated
Bing-su and others added 2 commits April 19, 2026 09:03
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 19, 2026
@ggerganov ggerganov merged commit 8685e7b into ggml-org:master Apr 19, 2026
6 checks passed
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Apr 21, 2026
* convert : support sentence-transformer 5.4 config files

* fix: embeddinggemma

* fix: mapping

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

* fix: pooling_mode

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Apr 23, 2026
* convert : support sentence-transformer 5.4 config files

* fix: embeddinggemma

* fix: mapping

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

* fix: pooling_mode

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
* convert : support sentence-transformer 5.4 config files

* fix: embeddinggemma

* fix: mapping

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

* fix: pooling_mode

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
jimbothigpen pushed a commit to jimbothigpen/frankenturbo2 that referenced this pull request May 2, 2026
* convert : support sentence-transformer 5.4 config files

* fix: embeddinggemma

* fix: mapping

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

* fix: pooling_mode

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* convert : support sentence-transformer 5.4 config files

* fix: embeddinggemma

* fix: mapping

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

* fix: pooling_mode

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>

---------

Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants