-
Notifications
You must be signed in to change notification settings - Fork 19.7k
mtmd, llama : Update HunyuanVL vision-language model support #22037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
89cd9b9
mtmd, llama : add HunyuanVL vision-language model support
741d7a7
fix: fix HunyuanVL XD-RoPE h/w section order
0a5a97c
fix: Remove redundant code
f829e27
convert : fix HunyuanOCR / HunyuanVL conversion
22a70c6
clip : fix -Werror=misleading-indentation in bilinear resize
96946e0
fix CI: convert_hf_to_gguf type check error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -197,6 +197,7 @@ class Rope: | |||||
| FREQ_BASE_SWA = "{arch}.rope.freq_base_swa" | ||||||
| SCALING_TYPE = "{arch}.rope.scaling.type" | ||||||
| SCALING_FACTOR = "{arch}.rope.scaling.factor" | ||||||
| SCALING_ALPHA = "{arch}.rope.scaling.alpha" | ||||||
| SCALING_ATTN_FACTOR = "{arch}.rope.scaling.attn_factor" | ||||||
| SCALING_ORIG_CTX_LEN = "{arch}.rope.scaling.original_context_length" | ||||||
| SCALING_FINETUNED = "{arch}.rope.scaling.finetuned" | ||||||
|
|
@@ -471,6 +472,7 @@ class MODEL_ARCH(IntEnum): | |||||
| ERNIE4_5_MOE = auto() | ||||||
| HUNYUAN_MOE = auto() | ||||||
| HUNYUAN_DENSE = auto() | ||||||
| HUNYUAN_VL = auto() | ||||||
| SMOLLM3 = auto() | ||||||
| GPT_OSS = auto() | ||||||
| LFM2 = auto() | ||||||
|
|
@@ -957,6 +959,7 @@ class MODEL_TENSOR(IntEnum): | |||||
| MODEL_ARCH.FALCON_H1: "falcon-h1", | ||||||
| MODEL_ARCH.HUNYUAN_MOE: "hunyuan-moe", | ||||||
| MODEL_ARCH.HUNYUAN_DENSE: "hunyuan-dense", | ||||||
| MODEL_ARCH.HUNYUAN_VL: "hunyuan_vl", | ||||||
| MODEL_ARCH.SMOLLM3: "smollm3", | ||||||
| MODEL_ARCH.GPT_OSS: "gpt-oss", | ||||||
| MODEL_ARCH.LFM2: "lfm2", | ||||||
|
|
@@ -3489,6 +3492,22 @@ class MODEL_TENSOR(IntEnum): | |||||
| MODEL_TENSOR.FFN_DOWN, | ||||||
| MODEL_TENSOR.FFN_UP, | ||||||
| ], | ||||||
| MODEL_ARCH.HUNYUAN_VL: [ | ||||||
| MODEL_TENSOR.TOKEN_EMBD, | ||||||
| MODEL_TENSOR.OUTPUT_NORM, | ||||||
| MODEL_TENSOR.OUTPUT, | ||||||
| MODEL_TENSOR.ATTN_NORM, | ||||||
| MODEL_TENSOR.ATTN_Q, | ||||||
| MODEL_TENSOR.ATTN_Q_NORM, | ||||||
| MODEL_TENSOR.ATTN_K, | ||||||
| MODEL_TENSOR.ATTN_K_NORM, | ||||||
| MODEL_TENSOR.ATTN_V, | ||||||
| MODEL_TENSOR.ATTN_OUT, | ||||||
| MODEL_TENSOR.FFN_NORM, | ||||||
| MODEL_TENSOR.FFN_GATE, | ||||||
| MODEL_TENSOR.FFN_DOWN, | ||||||
| MODEL_TENSOR.FFN_UP, | ||||||
| ], | ||||||
| MODEL_ARCH.SMOLLM3: [ | ||||||
| MODEL_TENSOR.TOKEN_EMBD, | ||||||
| MODEL_TENSOR.OUTPUT_NORM, | ||||||
|
|
@@ -4138,6 +4157,7 @@ class VisionProjectorType: | |||||
| YOUTUVL = "youtuvl" | ||||||
| NEMOTRON_V2_VL = "nemotron_v2_vl" | ||||||
| HUNYUANOCR = "hunyuanocr" | ||||||
| HUNYUANVL = "hunyuanvl_merger" | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
remove |
||||||
|
|
||||||
|
|
||||||
| # Items here are (block size, type size) | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -150,7 +150,7 @@ | |||||
| #define TN_TOK_BOI "v.boi" | ||||||
| #define TN_TOK_EOI "v.eoi" | ||||||
|
|
||||||
| // hunyuanocr | ||||||
| // hunyuanocr / hunyuanvl (shared GGUF tensor names) | ||||||
| #define TN_MM_PRE_NORM "mm.pre_norm.%s" | ||||||
| #define TN_TOK_IMG_BEGIN "mm.image_begin" | ||||||
| #define TN_TOK_IMG_END "mm.image_end" | ||||||
|
|
@@ -293,6 +293,7 @@ enum projector_type { | |||||
| PROJECTOR_TYPE_KIMIK25, | ||||||
| PROJECTOR_TYPE_NEMOTRON_V2_VL, | ||||||
| PROJECTOR_TYPE_HUNYUANOCR, | ||||||
| PROJECTOR_TYPE_HUNYUANVL, | ||||||
| PROJECTOR_TYPE_UNKNOWN, | ||||||
| }; | ||||||
|
|
||||||
|
|
@@ -338,6 +339,7 @@ static std::map<projector_type, std::string> PROJECTOR_TYPE_NAMES = { | |||||
| { PROJECTOR_TYPE_KIMIK25, "kimik25"}, | ||||||
| { PROJECTOR_TYPE_NEMOTRON_V2_VL, "nemotron_v2_vl"}, | ||||||
| { PROJECTOR_TYPE_HUNYUANOCR, "hunyuanocr"}, | ||||||
| { PROJECTOR_TYPE_HUNYUANVL, "hunyuanvl_merger"}, | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| }; | ||||||
|
|
||||||
| static projector_type clip_projector_type_from_string(const std::string & str) { | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this break the conversion of hunyuan-ocr ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully handled here, but needs testing:
llama.cpp/convert_hf_to_gguf.py
Lines 12071 to 12073 in 0a5a97c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngxson @CISC Addressed, tested locally: both HunyuanOCR and HunyuanVL convert to GGUF successfully and produce correct inference output on Metal (F16 / Q8_0). The only difference between OCR and VL is the projection dim (vision_config.out_hidden_size: 1024 for OCR)