ggml : add ggml_interpolate_sf() with explicit scale factors#22036
Closed
ManaEstras wants to merge 1 commit into
Closed
ggml : add ggml_interpolate_sf() with explicit scale factors#22036ManaEstras wants to merge 1 commit into
ManaEstras wants to merge 1 commit into
Conversation
- add ggml_interpolate_sf() API for explicit scale factor interpolation - add GGML_SCALE_FLAG_CUSTOM_SF flag - add support across all backends (CPU, CUDA, Metal, SYCL, Vulkan, OpenCL) - fix nearest interpolation out-of-bounds access - add 38 test cases for interpolate_sf in test-backend-ops
3 tasks
|
Hi @ManaEstras, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
ggml_interpolate_sf()API that accepts explicit scale factors for interpolation operations.Motivation
The existing
ggml_interpolate()computes scale factors internally asne_dst / ne_src. However, some vision-language models require interpolation with scale factors that cannot be expressed as simple dimension ratios.For example, when interpolating position embeddings, a model may use:
where
offsetis a learned or configured value (e.g., 0.1). This cannot be achieved by manipulating input/output tensor dimensions alone.This PR introduces
ggml_interpolate_sf()which allows the caller to specifysf0andsf1directly, enabling exact control over the interpolation coordinate mapping.Changes
API:
ggml_interpolate_sf(ctx, a, ne0, ne1, ne2, ne3, mode, sf0, sf1)GGML_SCALE_FLAG_CUSTOM_SFflagBackend support:
Bug fix:
Tests:
Testing
interpolate_sftests pass on CPUinterpolate_sftests pass on Metalctest -L mainpassesRequirements