Skip to content

kv-cache : fix crash in state save/restore #21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ehotting wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Draft

kv-cache : fix crash in state save/restore #21576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/llama-kv-cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,6 +1982,9 @@ void llama_kv_cache::state_write_data(llama_io_write_i & io, const cell_ranges_t
const uint32_t n_embd_k_gqa = hparams.n_embd_k_gqa(il);

auto * k = layer.k_stream[cr.strm];
if (!k || !k->data) {
continue;
}

// Write key type
const int32_t k_type_i = (int32_t) k->type;
Expand All @@ -2006,7 +2009,7 @@ void llama_kv_cache::state_write_data(llama_io_write_i & io, const cell_ranges_t
const uint32_t n_embd_v_gqa = hparams.n_embd_v_gqa(il);

auto * v = layer.v_stream[cr.strm];
if (!v) {
if (!v || !v->data) {
continue;
}

Expand Down Expand Up @@ -2035,7 +2038,7 @@ void llama_kv_cache::state_write_data(llama_io_write_i & io, const cell_ranges_t
const uint32_t n_embd_v_gqa = hparams.n_embd_v_gqa(il);

auto * v = layer.v_stream[cr.strm];
if (!v) {
if (!v || !v->data) {
continue;
}

Expand Down Expand Up @@ -2214,6 +2217,9 @@ bool llama_kv_cache::state_read_data(llama_io_read_i & io, uint32_t strm, uint32
const uint32_t n_embd_k_gqa = hparams.n_embd_k_gqa(il);

auto * k = layer.k_stream[strm];
if (!k || !k->data) {
continue;
}

// Read type of key
int32_t k_type_i_ref;
Expand Down Expand Up @@ -2255,7 +2261,7 @@ bool llama_kv_cache::state_read_data(llama_io_read_i & io, uint32_t strm, uint32
const uint32_t n_embd_v_gqa = hparams.n_embd_v_gqa(il);

auto * v = layer.v_stream[strm];
if (!v) {
if (!v || !v->data) {
continue;
}

Expand Down Expand Up @@ -2299,7 +2305,7 @@ bool llama_kv_cache::state_read_data(llama_io_read_i & io, uint32_t strm, uint32
const uint32_t n_embd_v_gqa = hparams.n_embd_v_gqa(il);

auto * v = layer.v_stream[strm];
if (!v) {
if (!v || !v->data) {
continue;
}

Expand Down