Skip to content

contrib : rewrite AGENTS.md, make it more clear about project values#21270

Merged
ngxson merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/agents_better
Apr 1, 2026
Merged

contrib : rewrite AGENTS.md, make it more clear about project values#21270
ngxson merged 2 commits into
ggml-org:masterfrom
ngxson:xsn/agents_better

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented Apr 1, 2026

Overview

Alternative to #21007

This version make it more clear about the values of the project:

  • We value human interactions
  • Human contributor must "own" the code
  • Contributor should be aware that a contribution is not just code, but also the planning and maintenance costs

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: yes, I wrote a broken english version and asked the AI to rewrite it; the idea is still mine

@ngxson ngxson requested a review from a team April 1, 2026 15:55
Comment thread AGENTS.md
Comment on lines +56 to +61
The following will result in immediate PR closure:

For related documentation on building, testing, and guidelines, please refer to:
- **AI-written PR descriptions or commit messages** - these are typically recognizable and waste reviewer time
- **AI-generated responses to reviewer comments** - this undermines the human-to-human interaction fundamental to code review
- **Implementing features without understanding the codebase** - particularly new model support or architectural changes
- **Automated commits or PR submissions** - this may spam maintainers and can result in contributor bans
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing code is no longer forbidden here. Note that I initially wrote this point as "no wall-of-text" and the AI rephrased it such that it sounds more professional

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGENTS.md is loaded as system instructions by agents. The "Guidelines for Contributors" section is project policy for humans that fills agent context without making them more effective (that's peanuts, but still...). Should that part stay in CONTRIBUTING.md, keeping AGENTS.md focused on what agents should/shouldn't do? 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point. It may be good to keep it shorter and only address the agent itself.

Copy link
Copy Markdown
Contributor Author

@ngxson ngxson Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current content takes around ~1200 tokens which is I think is still somewhat acceptable. Ofc it is possible to reduce it to around 500 tokens (will be a follow up PR). I don't think a second file will work, because in most cases there are no reasons for the agent to read it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's obviously possible to create a prompt that formats everything perfectly down to the smallest detail, like a human hardcore programmer, but it would be even harder to check. What a paradox

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply give the assistant a behavior that explains to the user that they need to know precisely what they want to do, that they must ask all the necessary architectural questions, and that the work of others must be respected, and that humans have to proofread everything and that it takes time? The perfect Inception approach…

Copy link
Copy Markdown
Contributor Author

@ngxson ngxson Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO prompting to change the behavior of the AI is almost like role play, and quite tricky to get right with heavily guarded models like claude or gpt.

Anw, I'm merging this PR as-is because it should already unblock some legitimate use cases for maintainers / contributors. Any improvement to this can be done via follow-up PRs.

@ngxson ngxson merged commit c30e012 into ggml-org:master Apr 1, 2026
2 checks passed
slartibardfast pushed a commit to slartibardfast/llama.cpp that referenced this pull request Apr 12, 2026
…gml-org#21270)

* contrib : rewrite AGENTS.md, make it more clear about types of permitted AI usage

* permit AI for writing code
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
…gml-org#21270)

* contrib : rewrite AGENTS.md, make it more clear about types of permitted AI usage

* permit AI for writing code
rsenthilkumar6 pushed a commit to rsenthilkumar6/llama.cpp that referenced this pull request May 1, 2026
…gml-org#21270)

* contrib : rewrite AGENTS.md, make it more clear about types of permitted AI usage

* permit AI for writing code
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
…gml-org#21270)

* contrib : rewrite AGENTS.md, make it more clear about types of permitted AI usage

* permit AI for writing code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants