server: remove the verbose_prompt parameter#21059
Conversation
|
Hi @aisk, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
ServeurpersoCom
left a comment
There was a problem hiding this comment.
LGTM. The TODO literally asked for this, verbose_prompt was already parsed but never wired up server-side. Clean fix, SRV_INF is the right level since the user explicitly opted in.
I think this is not accurate, I have two merged PRs for now: https://github.com/ggml-org/llama.cpp/pulls?q=is%3Apr+is%3Amerged+author%3Aaisk+ |
|
@CISC Hi thank you for your review. If we plan to not to support it, can we just remove this parameter in |
Yes, as suggested here #19752 (comment) :) |
|
Hi @CISC I updated this PR to just remove the |
* server: respect the verbose_prompt parameter * Revert "server: respect the verbose_prompt parameter" This reverts commit 8ed885c. * Remove --verbose-prompt parameter from llama-server * Using set_examples instead of set_excludes
* server: respect the verbose_prompt parameter * Revert "server: respect the verbose_prompt parameter" This reverts commit 8ed885c. * Remove --verbose-prompt parameter from llama-server * Using set_examples instead of set_excludes
* server: respect the verbose_prompt parameter * Revert "server: respect the verbose_prompt parameter" This reverts commit 8ed885c. * Remove --verbose-prompt parameter from llama-server * Using set_examples instead of set_excludes
* server: respect the verbose_prompt parameter * Revert "server: respect the verbose_prompt parameter" This reverts commit 8ed885c. * Remove --verbose-prompt parameter from llama-server * Using set_examples instead of set_excludes
Overview
When
verbose_promptcommand line argument is passed, print the prompt inllama-server. This should close or partial close #19653Requirements