Fix model selector locked to first loaded model with multiple models#20580
Merged
allozaur merged 2 commits intoggml-org:masterfrom Mar 16, 2026
Merged
Conversation
When multiple models are loaded, the auto-select effect would re-fire on every loadedModelIds change, overriding the user's manual model selection. Guard with selectedModelId so auto-select only kicks in when no model is chosen yet.
allozaur
force-pushed
the
webui/autoselect-model-new-conv-fix
branch
from
0e63be4 to
7d755aa
Compare
allozaur
approved these changes
Mar 16, 2026
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Mar 20, 2026
…gml-org#20580) * webui: fix model selector being locked to first loaded model When multiple models are loaded, the auto-select effect would re-fire on every loadedModelIds change, overriding the user's manual model selection. Guard with selectedModelId so auto-select only kicks in when no model is chosen yet. * chore: update webui build output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Fix model selector locked to first loaded model with multiple models
Fixes a regression from #20403 where, with multiple models loaded in
router mode, the user could not switch to any model other than the first
one.
The auto-select
$effectinChatFormActionswas re-firing on everyloadedModelIdschange (e.g. afterfetchRouterModelscompletes),overriding whatever the user had manually picked.
Fix: guard the else-if branch with
!modelsStore.selectedModelIdsoauto-select only kicks in when no model is chosen yet.
Close #20488