Skip to content

ggml/hip: fix APU compatibility - soft error handling for hipMemAdviseSetCoarseGrain #20536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohannesGaessler merged 2 commits into from
Mar 15, 2026
Merged

ggml/hip: fix APU compatibility - soft error handling for hipMemAdviseSetCoarseGrain #20536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e28c43
ggml/hip: fix APU compatibility - soft error handling for hipMemAdvis…
moonshadow-25 Mar 14, 2026
4c72b96
ggml/hip: remove unrelated changes, keep only hipMemAdviseSetCoarseGr…
moonshadow-25 Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ggml/src/ggml-cuda/ggml-cuda.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ static cudaError_t ggml_cuda_device_malloc(void ** ptr, size_t size, int device)
err = cudaMallocManaged(ptr, size);
#if defined(GGML_USE_HIP)
if (err == hipSuccess) {
CUDA_CHECK(cudaMemAdvise(*ptr, size, hipMemAdviseSetCoarseGrain, device));
// hipMemAdviseSetCoarseGrain is an optional performance hint;
// ignore errors (e.g. hipErrorInvalidValue on some APU/iGPU configs).
cudaMemAdvise(*ptr, size, hipMemAdviseSetCoarseGrain, device);
(void)hipGetLastError(); // clear any error
}

// fall back to cudaMalloc if not supported (e.g. on Windows)
Expand Down
Loading