tests: Fix invalid iterator::end() dereference in common_regex - #20445
Merged
ggerganov merged 1 commit intoMar 16, 2026
Conversation
rillomas
marked this pull request as ready for review
March 12, 2026 08:28
rillomas
changed the title
rillomas
changed the title
Contributor
Author
|
Hi @ggerganov, @CISC can you have a look at this (or assign someone sufficient)? Thanks |
aldehir
approved these changes
Mar 16, 2026
Contributor
|
I believe we have eliminated most, if not all, uses of the partial regex implementation. Still, I reproduced this and the fix works. Thanks! |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
my-other-github-account
pushed a commit
to my-other-github-account/llama.cpp
that referenced
this pull request
May 15, 2026
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
May 30, 2026
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
MrLordCat
referenced
this pull request
in MrLordCat/llama.cpp-rdna-lab
Jul 16, 2026
zommiommy
pushed a commit
to zommiommy/llama.cpp
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with VS2026 18.4 I noticed
test-regex-partialcrashes immediately with debug build.I tracked this down to an iterator::end() dereference in the following test case which was occurring here.
assert_equals<std::string>( "^(a*)", regex_to_reversed_partial_regex("a*"));This fix adds bounds checking to prevent such dereferencing.