common/autoparser : use nlohmann::ordered_json to preserve parameter order#20385
Merged
pwilkin merged 1 commit intoggml-org:masterfrom Mar 11, 2026
Merged
Conversation
aldehir
changed the title
CISC
approved these changes
Mar 11, 2026
pwilkin
approved these changes
Mar 11, 2026
Contributor
pwilkin
left a comment
pwilkin
left a comment
There was a problem hiding this comment.
Okay, that was a dumb mistake 😐
ProgenyAlpha
pushed a commit
to ProgenyAlpha/llama.cpp
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoparser used
nlohmann::json, which does not preserve order of parameters in tools. This confuses the model, as it attempts to emit parameters in the same order as the JSON schema but is grammar constrained from doing so.Wondering if this was the underlying issue in #20171.
Renamed
jsontoordered_jsonalias since it was conflicting with thejson()method.fixes #20359