Skip to content

llama-quant : correct n_attention_wv usage #20357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 2 commits into from
Mar 10, 2026
Merged

llama-quant : correct n_attention_wv usage #20357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df03a30
llama-quant : correct `n_attention_wv` usage
ddh0 Mar 10, 2026
a988640
simplify
ddh0 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/llama-quant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,9 +870,6 @@ static void llama_model_quantize_impl(const std::string & fname_inp, const std::

quantize_state_impl qs(model, params);

// these need to be set to n_layer by default
qs.n_ffn_down = qs.n_ffn_gate = qs.n_ffn_up = (int)model.hparams.n_layer;

if (params->only_copy) {
ftype = ml.ftype;
}
Expand Down Expand Up @@ -979,6 +976,22 @@ static void llama_model_quantize_impl(const std::string & fname_inp, const std::
// compute tensor metadata once and cache it
std::vector<tensor_metadata> metadata(tensors.size());

// initialize quantization state before preliminary loop (counters for use_more_bits)
{
for (size_t i = 0; i < tensors.size(); ++i) {
const auto cat = tensor_get_category(tensors[i]->tensor->name);
if (category_is_attn_v(cat)) {
++qs.n_attention_wv;
}
if (cat == tensor_category::OUTPUT) {
qs.has_tied_embeddings = false;
}
metadata[i].category = cat; // save and re-use the category while we're at it
}
// these also need to be set to n_layer by default
qs.n_ffn_down = qs.n_ffn_gate = qs.n_ffn_up = (int)qs.model.hparams.n_layer;
}

// flag for --dry-run
bool will_require_imatrix = false;

Expand All @@ -991,16 +1004,6 @@ static void llama_model_quantize_impl(const std::string & fname_inp, const std::
const struct ggml_tensor * tensor = it->tensor;
const std::string name = ggml_get_name(tensor);

metadata[i].category = tensor_get_category(name);

if (category_is_attn_v(metadata[i].category)) {
++qs.n_attention_wv;
}

if (tensor_name_match_output_weight(name.c_str())) {
qs.has_tied_embeddings = false;
}

uint16_t i_split = params->keep_split ? it->idx : 0;
if (!ctx_outs[i_split]) {
ctx_outs[i_split].reset(gguf_init_empty());
Expand Down
Loading