Skip to content

cli : fix --reasoning-budget and --chat-template-kwargs being ignored #20329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrevorS wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

cli : fix --reasoning-budget and --chat-template-kwargs being ignored #20329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tools/cli/cli.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,20 @@ struct cli_context {
inputs.parallel_tool_calls = false;
inputs.add_generation_prompt = true;
inputs.reasoning_format = COMMON_REASONING_FORMAT_DEEPSEEK;
inputs.enable_thinking = common_chat_templates_support_enable_thinking(chat_params.tmpls.get());
inputs.enable_thinking = chat_params.enable_thinking;
inputs.chat_template_kwargs = chat_params.chat_template_kwargs;

// sync enable_thinking with kwargs (mirrors server-common.cpp)
{
auto it = inputs.chat_template_kwargs.find("enable_thinking");
if (it != inputs.chat_template_kwargs.end()) {
if (it->second == "true") {
inputs.enable_thinking = true;
} else if (it->second == "false") {
inputs.enable_thinking = false;
}
}
}

// Apply chat template to the list of messages
return common_chat_templates_apply(chat_params.tmpls.get(), inputs);
Expand Down
Loading