ggml-vulkan: Add ELU op support#20183
Conversation
github-actions
bot
added
documentation
jeffbolznv
left a comment
jeffbolznv
left a comment
There was a problem hiding this comment.
Functionally this looks right (I haven't built/run it myself), just one question about the docs change.
| "Vulkan0","TANH","type=f16,ne_a=[5,7,11,13],v=0","support","1","yes","Vulkan" | ||
| "Vulkan0","ELU","type=f16,ne_a=[128,2,2,2],v=0","support","0","no","Vulkan" | ||
| "Vulkan0","ELU","type=f16,ne_a=[5,7,11,13],v=0","support","0","no","Vulkan" | ||
| "Vulkan0","ELU","type=f16,ne_a=[128,2,2,2],v=0","support","1","yes","Vulkan" |
There was a problem hiding this comment.
Did you manually edit this file? It hasn't been updated in 3 months and I doubt this is all that has changed. There are instructions to generate it in https://github.com/ggml-org/llama.cpp/blob/master/docs/ops.md.
There was a problem hiding this comment.
Hi, thank you for the feedback!
I did manually edit this file. I should have mentioned this.
I ran the command
$test-backend-ops support -b Vulkan0 --output csv
but the output only contained 13593 lines while the original Vulkan.csv contained 18741 lines.
Is this the expected behavior? Am I missing something?
There was a problem hiding this comment.
Thank you for the clarification.
I have updated Vulkan.csv and ops.md accordingly.
|
Please also fix the whitespace errors in EditorConfig. |
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
* ggml-Vulkan: add ELU support * ggml-Vulkan: remove extra spaces and variables * ggml-Vulkan: fix format issue * ggml-Vulkan: fix format issue * fix whitespace issue * Update Vulkan.csv and ops.md
3 participants
Add support for the ELU unary operation in the Vulkan backend.
First contribution, so all feedback is appreciated!
Related: #14909