Skip to content

jinja: correct stats for tojson and string filters#19785

Merged
ngxson merged 1 commit intoggml-org:masterfrom
ngxson:xsn/jinja_tojson_stats
Feb 22, 2026
Merged

jinja: correct stats for tojson and string filters#19785
ngxson merged 1 commit intoggml-org:masterfrom
ngxson:xsn/jinja_tojson_stats

Conversation

@ngxson
Copy link
Contributor

@ngxson ngxson commented Feb 21, 2026

Target fix #18675

@pwilkin please give this a try (see the added test case for more info)

@github-actions github-actions bot added testing Everything test related jinja parser Issues related to the jinja parser labels Feb 21, 2026
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Feb 22, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
@pwilkin
Copy link
Contributor

pwilkin commented Feb 22, 2026

@ngxson Cherry picked in #18675 and removed the workaround, can confirm it works correctly on all templates that in fact have tool definitions (found that Apertus had an incorrect macro for rendering tools, after correcting to OpenAI-compatible format it works as well).

@ngxson
Copy link
Contributor Author

ngxson commented Feb 22, 2026

@pwilkin hmm ok, if this works for you, please approve this PR so I can merge & proceed to review yours

@ngxson ngxson merged commit 5452d73 into ggml-org:master Feb 22, 2026
77 of 78 checks passed
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Feb 23, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
liparetejas pushed a commit to liparetejas/llama.cpp that referenced this pull request Feb 23, 2026
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Feb 25, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Feb 25, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Feb 27, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 2, 2026
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Mar 2, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Mar 3, 2026
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Mar 3, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
pwilkin added a commit to pwilkin/llama.cpp that referenced this pull request Mar 5, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
aldehir pushed a commit to aldehir/llama.cpp that referenced this pull request Mar 6, 2026
aldehir pushed a commit to aldehir/llama.cpp that referenced this pull request Mar 6, 2026
… fix Apertus template to require proper OpenAI compatible paths to tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jinja parser Issues related to the jinja parser testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants