Skip to content

ci : enable ggml sanitizers for webui#19415

Closed
CISC wants to merge 1 commit intomasterfrom
cisc/ci-fix-webui-sanitize
Closed

ci : enable ggml sanitizers for webui#19415
CISC wants to merge 1 commit intomasterfrom
cisc/ci-fix-webui-sanitize

Conversation

@CISC
Copy link
Member

@CISC CISC commented Feb 7, 2026

cont #19323

@CISC CISC requested a review from ggerganov February 7, 2026 12:31
@github-actions github-actions bot added the devops improvements to build systems and github actions label Feb 7, 2026
@ngxson
Copy link
Contributor

ngxson commented Feb 7, 2026

Maybe I missed something, but it seems like building llama-server and run server tests in webui workflow is redundant. I suppose @allozaur copied it from the normal server CI?

FWIW, there is just one single test in the whole test suite tools/server/tests that is related to webui, but it only test if -no-webui work correctly, so completely unrelated to webui build test.

I suppose the correct way is that: webui workflow only need to test if the svelte code is (1) well-formatted and (2) npm run build without any errors.

@CISC
Copy link
Member Author

CISC commented Feb 7, 2026

Maybe I missed something, but it seems like building llama-server and run server tests in webui workflow is redundant. I suppose @allozaur copied it from the normal server CI?

I guess, didn't really look too closely when I split it into its own workflow.

FWIW, there is just one single test in the whole test suite tools/server/tests that is related to webui, but it only test if -no-webui work correctly, so completely unrelated to webui build test.

It does seem to run different tests than server.yml though, maybe they need to be moved over there?

@ngxson
Copy link
Contributor

ngxson commented Feb 7, 2026

It does seem to run different tests than server.yml though, maybe they need to be moved over there?

It's not really different, but I guess because this code was copied from the version when we still use server/tests/tests.sh script in the workflow, so it sticking around until now. In any cases, I think it's safe to remove any pytest-related logic here and move them to server.yml workflow

@CISC CISC closed this Feb 7, 2026
@CISC
Copy link
Member Author

CISC commented Feb 7, 2026

Will follow up on #19411 instead.

@CISC CISC deleted the cisc/ci-fix-webui-sanitize branch February 7, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants