Skip to content

vendor : add missing llama_add_compile_flags #19322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CISC merged 10 commits into from
Feb 5, 2026
Merged

vendor : add missing llama_add_compile_flags #19322

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb3f06d
add missing llama_add_compile_flags
CISC Feb 4, 2026
c6296d6
remove fatal warnings definition
CISC Feb 4, 2026
c95bf10
override fatal warnings variable instead
CISC Feb 4, 2026
e42d896
try removing -Werror instead
CISC Feb 4, 2026
aaaf28c
attempt manipulating target properties instead
CISC Feb 4, 2026
6504727
try setting -Wno-unused-parameter
CISC Feb 4, 2026
8b435d1
replace cmake flags directly
CISC Feb 4, 2026
5d64848
remove target properties after add_subdirectory
CISC Feb 4, 2026
d878d24
target crypto directly
CISC Feb 4, 2026
201d6ba
disable all warnings for ssl, crypto and fipsmodule
CISC Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions vendor/cpp-httplib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@ license_add_file("cpp-httplib" "LICENSE")

find_package(Threads REQUIRED)

llama_add_compile_flags()

add_library(${TARGET} STATIC httplib.cpp httplib.h)
if (NOT MSVC)
# disable warnings in 3rd party code

# disable warnings in 3rd party code
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
target_compile_options(${TARGET} PRIVATE /w)
else()
target_compile_options(${TARGET} PRIVATE -w)
endif()

Expand Down Expand Up @@ -146,6 +151,23 @@ elseif (LLAMA_OPENSSL)
endif()
endif()

# disable warnings in 3rd party code
if(LLAMA_BUILD_BORINGSSL OR LLAMA_BUILD_LIBRESSL)
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
target_compile_options(ssl PRIVATE /w)
target_compile_options(crypto PRIVATE /w)
if(LLAMA_BUILD_BORINGSSL)
target_compile_options(fipsmodule PRIVATE /w)
endif()
else()
target_compile_options(ssl PRIVATE -w)
target_compile_options(crypto PRIVATE -w)
if(LLAMA_BUILD_BORINGSSL)
target_compile_options(fipsmodule PRIVATE -w)
endif()
endif()
endif()

if (CPPHTTPLIB_OPENSSL_SUPPORT)
target_compile_definitions(${TARGET} PUBLIC CPPHTTPLIB_OPENSSL_SUPPORT) # used in server.cpp
if (APPLE AND CMAKE_SYSTEM_NAME STREQUAL "Darwin")
Expand Down
Loading