vulkan: Enable topk_moe fusion for GLM-4.7-Flash#18947
Closed
jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
Closed
vulkan: Enable topk_moe fusion for GLM-4.7-Flash#18947jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
Conversation
Just need to add the fusion detection logic, this is a combination of existing modes (early softmax, bias, norm, scale), and is covered by the existing backend tests.
Contributor
Author
|
This may not be needed after #18980, I'll check once that lands. |
Contributor
Author
|
I verified the model is hitting TOPK_MOE_SIGMOID_NORM_BIAS now, without this change. So we don't really need the change. |
Contributor
|
So this can be closed? |
Contributor
Author
|
I'm fine with abandoning it. If another model needs it in the future the code will still be here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just need to add the fusion detection logic, this is a combination of existing modes (early softmax, bias, norm, scale), and is covered by the existing backend tests.