Skip to content

context : do not reserve scheduler for warmups #18867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 1 commit into from
Jan 15, 2026
Merged

context : do not reserve scheduler for warmups #18867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/llama-context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ llama_context::llama_context(
cparams.pipeline_parallel = pipeline_parallel;

if (cparams.pipeline_parallel) {
LLAMA_LOG_INFO("%s: pipeline parallelism enabled (n_copies=%d)\n", __func__, ggml_backend_sched_get_n_copies(sched.get()));
LLAMA_LOG_INFO("%s: pipeline parallelism enabled\n", __func__);
}

sched_reserve();
Expand Down Expand Up @@ -537,7 +537,8 @@ void llama_context::sched_reserve() {

const int64_t t_end_us = ggml_time_us();

LLAMA_LOG_INFO("%s: reserve took %.2f ms\n", __func__, (t_end_us - t_start_us)/1000.0);
LLAMA_LOG_INFO("%s: reserve took %.2f ms, sched copies = %d\n",
__func__, (t_end_us - t_start_us)/1000.0, ggml_backend_sched_get_n_copies(sched.get()));
}

void llama_context::synchronize() {
Expand Down Expand Up @@ -1011,7 +1012,8 @@ void llama_context::set_warmup(bool value) {

cparams.warmup = value;

sched_need_reserve = true;
// warmups are usually with small batches, so no need to reserve
//sched_need_reserve = true;
}

bool llama_context::set_sampler(llama_seq_id seq_id, llama_sampler * sampler) {
Expand Down
Loading