Merged
Conversation
Contributor
Author
|
ref: #18648 (comment) |
ngxson
approved these changes
Jan 7, 2026
Contributor
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
We should also remove 2 places where linenoise is mentioned:
- at the end of main
README.mdwhere we list the deps - in
licences
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
angt
force-pushed
the
tools-remove-llama-run
branch
from
41878a7 to
294b2b4
Compare
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
taronaeo
approved these changes
Jan 7, 2026
Contributor
Author
|
Lets go! In case of drama we can still revert 😬 |
gary149
pushed a commit
to gary149/llama-agent
that referenced
this pull request
Jan 8, 2026
* tools : remove llama-run * Remove licenses/LICENSE-linenoise Signed-off-by: Adrien Gallouët <angt@huggingface.co>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.