ggml-cuda: fix regex for arch list#18371
Merged
am17an merged 2 commits intoggml-org:masterfrom Dec 25, 2025
Merged
Conversation
Contributor
Author
|
@Panchovix not sure why there's an '^' at the end of if statement, copy-paste error? |
|
@am17an oof my bad! Now with the corrected regex, I can build with either native (not setting a CUDA arch), DCMAKE_CUDA_ARCHITECTURES native and DCMAKE_CUDA_ARCHITECTURES 86;89;120. I assume either of these 3 will include mxfp4 support? |
JohannesGaessler
approved these changes
Dec 25, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* ggml-cuda: fix regex for arch list * make regex exact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎄 https://xkcd.com/1171/