Skip to content

Comments

HIP: fix compile error on windows and merge I_MAJOR_DUAL to I_MAJOR_MIRRORED#18157

Merged
JohannesGaessler merged 1 commit intoggml-org:masterfrom
zhang-hui-yulo:fix_windows_for_rdna
Dec 18, 2025
Merged

HIP: fix compile error on windows and merge I_MAJOR_DUAL to I_MAJOR_MIRRORED#18157
JohannesGaessler merged 1 commit intoggml-org:masterfrom
zhang-hui-yulo:fix_windows_for_rdna

Conversation

@zhang-hui-yulo
Copy link
Contributor

@zhang-hui-yulo zhang-hui-yulo commented Dec 18, 2025

Fix compile error on windows. Passed on ROCm 7.1.1 Linux 9070XT, HIP 6.4.2 Windows 7900XTX and CUDA 12.9 Windows 3080.

Merge I_MAJOR_DUAL into I_MAJOR_MIRRORED, @JohannesGaessler could you help to do a quick test on Volta? Thank you.

@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Dec 18, 2025
@zhang-hui-yulo zhang-hui-yulo marked this pull request as draft December 18, 2025 08:51
@zhang-hui-yulo zhang-hui-yulo marked this pull request as ready for review December 18, 2025 08:51
@JohannesGaessler JohannesGaessler merged commit 54189c0 into ggml-org:master Dec 18, 2025
61 of 67 checks passed
@zhang-hui-yulo zhang-hui-yulo deleted the fix_windows_for_rdna branch December 20, 2025 04:59
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
Co-authored-by: zhang hui <you@example.com>
blime4 pushed a commit to blime4/llama.cpp that referenced this pull request Feb 5, 2026
Co-authored-by: zhang hui <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants