server: delegate result_state creation to server_task#17835
Merged
ngxson merged 5 commits intoggml-org:masterfrom Dec 8, 2025
Merged
server: delegate result_state creation to server_task#17835ngxson merged 5 commits intoggml-org:masterfrom
ngxson merged 5 commits intoggml-org:masterfrom
Conversation
6 tasks
ggerganov
reviewed
Dec 8, 2025
| tasks.push_back(std::move(task)); | ||
| } | ||
|
|
||
| rd.set_states(std::move(states)); |
Member
There was a problem hiding this comment.
states looks unused now - shouldn't it be removed?
ggerganov
approved these changes
Dec 8, 2025
0Marble
pushed a commit
to 0Marble/llama.cpp
that referenced
this pull request
Dec 18, 2025
* server: delegate result_state creation to server_task * remove unued states * add more docs
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* server: delegate result_state creation to server_task * remove unued states * add more docs
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* server: delegate result_state creation to server_task * remove unued states * add more docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #17775 (comment)