Skip to content

Refactor: convert_hf_to_gguf.py#17114

Draft
pwilkin wants to merge 8 commits intoggml-org:masterfrom
pwilkin:convert_refactor
Draft

Refactor: convert_hf_to_gguf.py#17114
pwilkin wants to merge 8 commits intoggml-org:masterfrom
pwilkin:convert_refactor

Conversation

@pwilkin
Copy link
Contributor

@pwilkin pwilkin commented Nov 9, 2025

From the creators of the horror show "llama-model.cpp - refactoring" comes the sequel: "convert_hf_to_gguf.py - refactoring".

Still in draft because it's not all finished, but I thought that if someone wanted to chime in I'll put it up already.

@CISC
Copy link
Member

CISC commented Nov 9, 2025

🤯 Looks like a decent enough plan though. Only downside is that there will no longer just be a single script to grab and run, but that has been a source of error and confusion anyway.

You should derive _MODEL_MODULES from models_map.

@CISC
Copy link
Member

CISC commented Nov 9, 2025

@compilade Your input would be much appreciated as well.

@CISC CISC added the refactoring Refactoring label Nov 9, 2025
@compilade
Copy link
Collaborator

(note for later) This will (trivially) conflict with at least

@CISC
Copy link
Member

CISC commented Nov 9, 2025

Are you expecting more work on these? Can be merged now.

@pwilkin
Copy link
Contributor Author

pwilkin commented Nov 12, 2025

Okay, so I've actually gone over and verified the conversion results - refactored, applied some tips from here while doing that and most of all - tested that it actually works.

@pwilkin
Copy link
Contributor Author

pwilkin commented Nov 18, 2025

@pwilkin pwilkin marked this pull request as ready for review November 18, 2025 16:06
@pwilkin pwilkin requested a review from CISC as a code owner November 18, 2025 16:06
@pwilkin
Copy link
Contributor Author

pwilkin commented Nov 18, 2025

@CISC have fun! :)

@CISC
Copy link
Member

CISC commented Nov 18, 2025

@CISC have fun! :)

You need to fix the CIs first, esp. convert_hf_to_gguf_update.py. :)

@pwilkin
Copy link
Contributor Author

pwilkin commented Nov 18, 2025

Yeah, might've went out of draft too early :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants