cmake: add option to build and link BoringSSL#17062
cmake: add option to build and link BoringSSL#17062angt wants to merge 4 commits intoggml-org:masterfrom
Conversation
This commit adds an easy way to fetch, build, and statically link the BoringSSL library when LLAMA_BUILD_BORINGSSL is enabled. The version can be set via the LLAMA_BORINGSSL_VERSION cache variable. Signed-off-by: Adrien Gallouët <angt@huggingface.co>
|
Few observations:
|
As a quick fix, I can support
Yes, my plan is to progressively remove |
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
| option(LLAMA_LLGUIDANCE "llama-common: include LLGuidance library for structured output in common utils" OFF) | ||
| option(LLAMA_CURL "llama: use libcurl to download model from an URL" ON) | ||
| option(LLAMA_OPENSSL "llama: use openssl to support HTTPS" OFF) | ||
| option(LLAMA_BUILD_BORINGSSL "llama: build and statically link BoringSSL" OFF) |
There was a problem hiding this comment.
Any reason to call this LLAMA_BUILD_BORINGSSL instead of the more consistent LLAMA_BORINGSSL?
There was a problem hiding this comment.
I wanted to emphasize that we don’t just use BoringSSL (like we use OpenSSL with LLAMA_OPENSSL), but actually build it. But we can definitely use LLAMA_BORINGSSL.
Also, I think we can simply use BORINGSSL_VERSION to specify the version?
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
|
Quick heads up, BoringSSL does not support the s390x platform due to endianness issues. So if possible for CI tests, exclude s390x from the BoringSSL tests. |
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
|
I'll refactor this PR after the merge of #17177 |
|
supersed by #17205 |
This commit adds an easy way to fetch, build, and statically link the BoringSSL library when LLAMA_BUILD_BORINGSSL is enabled.
The version can be set via the LLAMA_BORINGSSL_VERSION cache variable.