vulkan: fix shmem overrun in mmq id shader #16873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cc4m
force-pushed
the
0cc4m/vulkan-workaround-mmqid-shmem-bug
branch
from
5ad117d to
c9d7147
Compare
jeffbolznv
reviewed
Oct 30, 2025
jeffbolznv
approved these changes
Oct 30, 2025
Member
|
@ggerganov Metal seems to fail this case as well. |
slaren
approved these changes
Oct 30, 2025
github-actions
bot
added
testing
LostRuins
added a commit
to LostRuins/koboldcpp
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue caused incoherence in gpt-oss. I forgot to update the shared memory limits for the mmq id shader, and it looks like it overran the limit. I'll create a proper solution later, this change resolves the incoherence for now.