CUDA: better error for FA kernel with 0 occupancy #16643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
am17an
approved these changes
Oct 20, 2025
slaren
approved these changes
Oct 20, 2025
ye-NX
pushed a commit
to ye-NX/llama.cpp
that referenced
this pull request
Oct 21, 2025
FMayran
pushed a commit
to FMayran/llama.cpp
that referenced
this pull request
Oct 23, 2025
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unable to reproduce it but in #16633 someone was somehow able to get an occupancy of 0 for a kernel. This PR adds an assert in order to get a better error than an arithmetic exception.